pubsub/gossipsub/README: Mark rust gossipsub v1.0 as complete #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yes, it is complete up to what is written in the spec. We don't have signed peer records, but that is not gossipsub-specific. Anyone wanting further features into our gossipsub, they can make issues to the repo and we can add them. I think we should mark it as complete in specs. |
BigLep
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libp2p/rust-libp2p#898 and libp2p/rust-libp2p#1720 I think it is safe to say that the Rust GossipSub v1.0 implementation is complete.
@AgeManning please correct me in case I am missing something.