-
Notifications
You must be signed in to change notification settings - Fork 296
webrtc/: Add libp2p WebRTC browser-to-server spec #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
135 commits
Select commit
Hold shift + click to select a range
9677aa2
webrtc/: Add libp2p WebRTC specification
mxinden 968d127
webrtc/: Document RTCCertificate#getFingerprints
mxinden 64a3dff
webrtc/: Extend protocol flow
mxinden 7dfcca1
webrtc/: Mention SDP exchange through relay and DCUtR
mxinden 28e341b
webrtc/: Stress that A can build B's SDP offer locally
mxinden b3bd981
webrtc/: Add B's peer ID to B's multiaddr
mxinden dc6fb4e
webrtc/: Add FAQ section
mxinden 9728e22
webrtc/: Do additional auth handshake to prevent replay attack
mxinden 13f6aaa
webrtc/: Differentiate in Browser->Server and Browser->Browser
mxinden 7ec96db
webrtc/: Document open question of B learning A's fingerprint
mxinden 5f5fd60
webrtc/: Detail generic RTCPeerConnection creation
mxinden 84d4c41
webrtc/: Describe address scheme
mxinden 9790d1a
webrtc/: Document open question of B learning A's fingerprint
mxinden 4c6320e
webrtc/: Fix outdated multiaddrs
mxinden 449462b
webrtc/: Document open question of key derivation for TLS cert
mxinden 3e9fb70
webrtc/: Determine UDP port for browser-to-browser
mxinden 81249f3
webrtc/: Add open question on udp vs tcp
mxinden ee09ed4
webrtc/README: Update with reuse of certificates
mxinden d451652
webrtc/: Answer question no double muxing
mxinden b485340
webrtc/: Reword connecting to instantiating
mxinden b654f11
webrtc/: Document generating valid SDP packet
mxinden 9a90f0d
webrtc/: Restructure sections with Open Questions section each
mxinden baccb1d
webrtc/: Document DCUtR in browser-to-browser use-case
mxinden 83e7aa0
webrtc/: Document client fingerprint in STUN username
mxinden 766bb62
webrtc/: Detail Multiplexing and Security in separate section
mxinden 525bc9e
webrtc/: Document UDP port multiplexing and ICE lite
mxinden 3e9e6df
webrtc/: Document potential attack vectors using STUN
mxinden a29cb45
webrtc/: Write out additional Noise handshake
mxinden 827def2
webrtc/: Delete outdated comment on browsers
mxinden e6c23e1
webrtc/: Document Firefox not connecting on localhost
mxinden 5f7ea61
webrtc/: Document random string in STUN username and password
mxinden f5eb1b7
webrtc/: Document potential amplification defense through large clien…
mxinden a8a42b5
webrtc/: Document certhash being a multibase encoded multihash
mxinden c8e725a
webrtc/: Document hash function match on WebRTC and Noise
mxinden 7e601e7
webrtc/: Track open question on whether server should initiate Noise
mxinden 9e8ec87
webrtc/readme/faq: Write out the need for handshake over plain sigs
mxinden cceed49
webrtc/: Fix typo fingerprint -> signature
mxinden c5522c4
webrtc/: Document open question on Noise optimization
mxinden c89a72a
webrtc/: Reword Motivation section
mxinden bc76a06
webrtc/: Document UDP port per RTCPeerConnection
mxinden a0ae9b0
webrtc/: Extend on UDP muxing support across implementations
mxinden 774cd52
webrtc/: Document SDP munging
mxinden ae1020b
webrtc/: Document Noise Prologue mechanism
mxinden 4b8e890
webrtc/: Require signature tag and sorted fingerprints
mxinden 285574d
webrtc/: Add message framing to support half-close and reset of stream
mxinden 7009f94
webrtc/: Specify sha256 and base64url
mxinden 373bafe
webrtc/: Reword protobuf comment from local endpoint to sender
mxinden 93df7e3
webrtc/: Adapt enum variants to QUIC RFC
mxinden 027b539
webrtc/: Link QUIC RFC as reference
mxinden 865f4f2
webrtc/: Redefine RESET semantics
mxinden a60234c
webrtc/: Rephrase missing mechanism in browser webrtc api
mxinden 48f5fe7
webrtc/: Add note on stream ordering
mxinden 7f40491
Apply suggestions from code review
mxinden 31ac65d
webrtc/: Require RESET after STOP_SENDING
mxinden 85364f4
webrtc/: Rename RESET to RESET_STREAM
mxinden 9ce0d45
webrtc/: Allow overriding ordering on a data channel
mxinden 2570b24
Merge branch 'webrtc' of github.com:mxinden/specs into webrtc-msg-fra…
mxinden 7a8ebc0
webrtc/: Use message framing for Noise handshake already
mxinden f0acbb5
Update webrtc/README.md
mxinden 6df6cf3
Merge pull request #1 from mxinden/webrtc-msg-framing
mxinden c19ba8a
webrtc/README.md: Fix typo
mxinden 65a894a
webrtc/: Don't require STREAM_RESET in response to STOP_SENDING
mxinden 6fb2750
Add initial test vector for noise prologue
thomaseizinger 73516b1
Add note about encoding
thomaseizinger 8208f02
webrtc/: Document option for not using trickle ICE
mxinden 6c7f18e
webrtc/: Mention icegatheringstatechange event on the browser
mxinden 666c9f4
webrtc/: Use id 0 and negotiated true for Noise channel
mxinden ae5b0d8
webrtc/: Document allowing streams before Noise finished
mxinden 7ce6213
webrtc/: Use IP + port + ufrag for multiplexing
mxinden a2d1547
webrtc/: Remove open question on SDP munging
mxinden ded63c5
webrtc/: Reword certificate verification section
mxinden 54f8264
webrtc/: Recommend against reusing the TLS certificate
mxinden 67e12da
webrtc/: Document B listening via UDP socket
mxinden 4a52edc
webrtc/: Add uvarint link
mxinden 7380483
webrtc/: Remove mention of saved round trip
mxinden c063a81
webrtc/: Move fingerprint extraction to statement instead of question
mxinden 65590f9
webrtc/: Remove obsolete question on preceeding SDP packet
mxinden 8dc6465
webrtc/: Remove open question on handshake security
mxinden daecb5b
README.md: Link to WebRTC specification
mxinden 6267324
Merge branch master into webrtc
mxinden 590c3db
connections/hole-punching: Link to WebRTC specification
mxinden a207aa5
webrtc/: Document open questions on data channel IDs
mxinden ed5c641
webrtc/: Document head-of-line blocking
mxinden 42e7a20
webrtc/: Recommend concrete maximum message size
mxinden 3315b5c
webrtc/: Document stream negotiation and ids
mxinden 2dddfdc
webrtc/: Remove open questions on data channel negotiation and ids
mxinden 0deaa30
webrtc/: Make certificate reuse a SHOULD NOT
mxinden 7ac21aa
webrtc/: Fix typo
mxinden 8803682
webrtc/: Draft the browser-to-browser section
mxinden b5466fd
webrtc/: Have B start Noise handshake
mxinden 4931f87
webrtc/: Fix fingerprint hash algorithm to sha-256
mxinden d5d164b
webrtc/: Document replacement of webrtc direct and star
mxinden 6775d10
webrtc/: Document setting ondatachannel callback before noise
mxinden 730dca0
webrtc/: Order Protologue fingerprints by role not by sorting
mxinden faf641d
webrtc/: Use RTCDataChannel `negotiated: false`
mxinden e2df94c
webrtc/: Link to RFC and not Chromium codebase for stream reuse
mxinden b268693
webrtc/: Rephrase stream reuse and mention concurrent limit
mxinden 3aebc68
webrtc/: Drop hope for not having to use STUN
mxinden 50b4e12
webrtc/: Rephrase requirements as FAQs
mxinden c8df617
webrtc/: Document setting username and password on local and remote SDP
mxinden 4de8f96
webrtc/: Document amplification and DOS attack defense
mxinden 4dcf801
webrtc/: Document reason for B starting noise handshake
mxinden 16e38fb
webrtc/: Remove derivation of TLS certificate
mxinden f635466
webrtc: Document MUST for UDP and MAY for TCP
mxinden 5c9b600
Merge branch 'master' of https://github.com/libp2p/specs into webrtc
mxinden 961ada2
Merge remote-tracking branch 'mxinden/webrtc' into prologue-test-vectors
thomaseizinger 75c3b5c
Update test vector to remove sorting requirement
thomaseizinger 9abf638
webrtc/: Document RTCDataChannel label to be an empty string
mxinden 1cb4093
webrtc/: Track RTCDatachannel label in TOC
mxinden a46919c
webrtc/: Remove browser-to-browser use-case
mxinden 3058fb9
webrtc/: Update "Previous, ongoing and related work" section
mxinden a382f18
webrtc/: Add revision
mxinden 44fd082
webrtc/: Fix interest group links
mxinden 22fc557
Merge pull request #2 from thomaseizinger/prologue-test-vectors
mxinden 1ddc317
webrtc/: Document role on test vectors
mxinden 1e3ca59
webrtc/: Fix typo generating an offer for B
mxinden b1f629a
webrtc/: Fix more offer answer confusions
mxinden 070ebea
webrtc/: Reword server generating SDP offer
mxinden 072c317
Update webrtc/README.md
mxinden b8dc6fd
webrtc/: Mark server's peer ID as optional
mxinden a62fdd2
Update webrtc/README.md
mxinden 118a4dc
Merge remote-tracking branch 'libp2p/master' into webrtc
mxinden 60ac97a
webrtc/: Mention WebTransport specification
mxinden 6846d34
webrtc/: s/listen/bind for UDP socket
mxinden c369f2b
Update webrtc/README.md
mxinden 0c4e836
Update webrtc/README.md
mxinden dd9756b
webrtc/: Fix maximum packet size calculation
mxinden 249ebd2
webrtc/: Mention head-of-line-blocking on packet size recommendation
mxinden be5cfeb
webrtc/: Emphasize prologue prefix representation in bytes
mxinden 602f492
webrtc/: Require A to use same hash alg as B and REQUIRE sha-256 support
mxinden 1c7956c
webrtc/: Prefix random ufrag string for future upgrades
mxinden b5ac74b
webrtc/README.md: Refer to plural RTCDataChannel
mxinden b6e7eb1
webrtc/README.md: Use valid ufrag prefix
mxinden 2d0478c
webrtc/: Add max-message-size SDP attribute
mxinden 4dc788c
webrtc/: Fix typo
mxinden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
webrtc/: Document random string in STUN username and password
- Loading branch information
commit 5f7ea61484e4e777048d84273693504ff51a88df
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t understand this sentence. What does upgrading as an insecure connection mean, as opposed to upgrading as a secure connection?
I think we should avoid the term „upgrading“ altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ded63c5 rephrases the section. @marten-seemann let me know what you think.