Skip to content

Conversation

@thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Jan 24, 2024

See libp2p/rust-libp2p#5119.

Resolves: #343.

@thomaseizinger thomaseizinger requested review from mxinden and removed request for mxinden January 24, 2024 05:42
@thomaseizinger thomaseizinger changed the title fix: update Rust v0.52 hash to fix build error fix: update rust-v0.52 hash to fix build error Jan 24, 2024
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump works for me. But all rust-v0.52 testcases are failing now.

@thomaseizinger
Copy link
Contributor Author

Bump works for me. But all rust-v0.52 testcases are failing now.

Yeah I noticed, what the heck. How can the glibc version not match when it is built literally in that container.

@thomaseizinger
Copy link
Contributor Author

Bump works for me. But all rust-v0.52 testcases are failing now.

Yeah I noticed, what the heck. How can the glibc version not match when it is built literally in that container.

It appears the glibc version in distroless is not recent enough.

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger
Copy link
Contributor Author

Hmm, should I use debian-12 as the base image or back-port the static-linking stuff we already have on main in rust-libp2p?

See https://github.com/libp2p/rust-libp2p/blob/master/interop-tests/Dockerfile.native.

@thomaseizinger
Copy link
Contributor Author

Hmm, should I use debian-12 as the base image or back-port the static-linking stuff we already have on main in rust-libp2p?

See libp2p/rust-libp2p@master/interop-tests/Dockerfile.native.

I think I'll move forward with the updated base image. The static linking might need some tweaks actually.

@thomaseizinger
Copy link
Contributor Author

And of course the glibc version in the selenium base image is also old.

@thomaseizinger
Copy link
Contributor Author

I am disabling the chromium tests for now to unblock this. I don't have the resources to investigate this right now.

@thomaseizinger thomaseizinger merged commit d1d9e18 into master Jan 24, 2024
@thomaseizinger thomaseizinger deleted the fix/update-rust-v0.52 branch January 24, 2024 20:47
codemaestro64 pushed a commit to codemaestro64/test-plans that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build rust-libp2p during interop test run

3 participants