dashboards: switch to irate for peer bytes sent/recv #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we switch to using an `irate` over the past minute for the peer graphs. The cumulative graph wasn't very helpful, since it can be skewed when peers connect/reconnect. This new `irate` format is better as you can at a glance, spot anomalies (spikes in sent/recv) easily. We also fix some graphs that were graph satoshis instead of bytes (kek), and use a longer interval for the peer flappiness graph to make it smoother.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we switch to using an
irateover the past minute forthe peer graphs. The cumulative graph wasn't very helpful, since it can
be skewed when peers connect/reconnect. This new
irateformat isbetter as you can at a glance, spot anomalies (spikes in sent/recv)
easily.
We also fix some graphs that were graph satoshis instead of bytes (kek),
and use a longer interval for the peer flappiness graph to make it
smoother.
Nu graphs: