Add Channel Uptime Percentage #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Dec 11, 2019
carlaKC
force-pushed
the
uptime-percentage
branch
from
e633698 to
fa3a2a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the remote node's uptime percentage to the node stats dashboard per channel we have open. This change relies on the experimental uptime field in `lnstchannels``.
This change could be generalized to adding uptime for all peers if we updated peer tracking to
listpeersin lnd (which may be worth doing), or moved onto the peers dashboard if we calllistchannelsin the peers collector then just set uptime for the peers that we currently have channels for.