collectors: add close metrics #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
close-metrics
branch
from
2c879c5 to
09d7176
Compare
|
@carlaKC are you open to accepting this PR? |
Yes, looks like a nice change to have! Self assigned review, will get to it this week. |
carlaKC
reviewed
Feb 15, 2021
There was a problem hiding this comment.
Happy with the addition of this metric, but I'd like to pair it with adding some panels to the provisioned grafana dash since I'd imagine most people will use the full docker-compose setup. Just pending channels by state and closed channels by close type will do I think.
joostjager
force-pushed
the
close-metrics
branch
from
09d7176 to
2dd486f
Compare
|
Panels added |
carlaKC
approved these changes
Feb 17, 2021
joostjager
force-pushed
the
close-metrics
branch
from
2dd486f to
c38d6f2
Compare
|
Hmm yes, I missed that. Merged dashboards. |
joostjager
force-pushed
the
close-metrics
branch
from
c38d6f2 to
68e4e01
Compare
|
Thanks for the PR, latest iteration looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds metrics so that a prometheus alert can be set up when a force-close happens. This is an event that unfortunately still seems to occur occasionally.
Example of an alert that becomes active if at least one channel was force-closed in the past 24 hours:
round(sum(delta(lnd_closed_channels_total{close_type="local_force"}[1d]) or delta(lnd_closed_channels_total{close_type="remote_force"}[1d]) or delta(lnd_channels_pending_total{state="pending_force_close"}[1d]))) > 0