collectors: summarize limbo channel balances to avoid stuck values #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how we collect limbo balances to calculate summaries instead of separate series by channel, peer, status etc. Having just the summaries makes it possible to correctly select the last known total value which was previously not feasible when summarizing over longer periods due to values with channel/peer specific labels getting "stuck".
guggero
approved these changes
Feb 20, 2023
tools/Dockerfile
Outdated
| && go install -trimpath -tags=tools github.com/golangci/golangci-lint/cmd/golangci-lint \ | ||
| && chmod -R 777 /tmp/build/ | ||
| && chmod -R 777 /tmp/build/ \ | ||
| && git config --global --add safe.directory /build |
There was a problem hiding this comment.
We found the actual problem for the linter error (a Golang bug) and a fix that allows us to determine more easily if it's fixed in a future version. See https://github.com/lightninglabs/pool/blob/master/tools/Dockerfile#L6.
There was a problem hiding this comment.
Thanks, sound much better.
bhandras
force-pushed
the
limbo-balance-summary
branch
from
0727052 to
1aac677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how we collect limbo balances to calculate summaries instead of separate series by channel, peer, status etc. Having just the summaries makes it possible to correctly select the last known total value which was previously not feasible when summarizing over longer periods due to values with channel/peer specific labels getting "stuck".