Skip to content

Optimize Parcel Resumption and Reduce Blocking in ChainPorter #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ffranr wants to merge 3 commits into from
Closed

Optimize Parcel Resumption and Reduce Blocking in ChainPorter #1068

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e3ffae
tapfreighter: reposition WaitGroup.Done() call for better clarity
ffranr Aug 8, 2024
b9b3062
tapfreighter: buffer outboundParcels channel to prevent blocking
ffranr Aug 8, 2024
9ac1baa
tapfreighter: exec ChainPorter.resumePendingParcels in new goroutine
ffranr Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tapfreighter/chain_porter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,10 @@ func (p *ChainPorter) Start() error {

// Start the main chain porter goroutine.
p.Wg.Add(1)
go p.mainEventLoop()
go func() {
defer p.Wg.Done()
p.mainEventLoop()
}()

startErr = p.resumePendingParcels()
})
Expand Down Expand Up @@ -311,8 +314,6 @@ func (p *ChainPorter) QueryParcels(ctx context.Context,
// requests, and attempt to complete a transfer. A response is sent back to the
// caller if a transfer can be completed. Otherwise, an error is returned.
func (p *ChainPorter) mainEventLoop() {
defer p.Wg.Done()
Copy link
Contributor

@guggero guggero Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a NOTE comment to this method that it MUST be run as a goroutine.
Normally, the defer p.Wg.Done() at the start of a method indicates this to someone reading the code.


for {
select {
case outboundParcel := <-p.outboundParcels:
Expand Down