Added new constructor for tracer that propagates error.#228
Merged
codeboten merged 1 commit intolightstep:masterfrom Oct 28, 2019
Merged
Added new constructor for tracer that propagates error.#228codeboten merged 1 commit intolightstep:masterfrom
codeboten merged 1 commit intolightstep:masterfrom
Conversation
bwplotka
force-pushed
the
newtracer-error
branch
from
98ec582 to
254a791
Compare
2 tasks
Contributor
Author
|
Any ideas what's wrong with this test? |
Contributor
|
Hi @bwplotka! The test problem seems to be unrelated to your change. @codeboten just added #229, which should mitigate the timeout issue. |
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
newtracer-error
branch
from
254a791 to
a12a137
Compare
codeboten
approved these changes
Oct 28, 2019
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the contribution!
|
@iredelmeier @codeboten is there a timeline for a new release that includes this patch? |
Contributor
|
@antonio hopefully looking at releasing before the end of the week |
|
@codeboten awesome, thanks. |
antonio
added a commit
to antonio/thanos
that referenced
this pull request
Nov 18, 2019
lightstep/lightstep-tracer-go#228 introduced a new method to create a Tracer that returns an error when it does not succeed, instead of nil Signed-off-by: Antonio Santos <antonio@santosvelasco.com>
GiedriusS
pushed a commit
to thanos-io/thanos
that referenced
this pull request
Nov 19, 2019
* Add support for tracing with Lightstep Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove type cast Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Add documentation for the exported methods and types Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Apply suggestions from @bwplotka Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Inline variable Co-Authored-By: Povilas Versockas <p.versockas@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Update lightstep library and add proper error handling lightstep/lightstep-tracer-go#228 introduced a new method to create a Tracer that returns an error when it does not succeed, instead of nil Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove unused import Signed-off-by: Antonio Santos <antonio@santosvelasco.com>
IKSIN
pushed a commit
to monitoring-tools/thanos
that referenced
this pull request
Nov 26, 2019
* Add support for tracing with Lightstep Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove type cast Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Add documentation for the exported methods and types Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Apply suggestions from @bwplotka Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Inline variable Co-Authored-By: Povilas Versockas <p.versockas@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Update lightstep library and add proper error handling lightstep/lightstep-tracer-go#228 introduced a new method to create a Tracer that returns an error when it does not succeed, instead of nil Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove unused import Signed-off-by: Antonio Santos <antonio@santosvelasco.com> Signed-off-by: Aleksey Sin <asin@ozon.ru>
fatsheep9146
pushed a commit
to fatsheep9146/thanos
that referenced
this pull request
Dec 4, 2019
* Add support for tracing with Lightstep Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove type cast Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Add documentation for the exported methods and types Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Apply suggestions from @bwplotka Co-Authored-By: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Inline variable Co-Authored-By: Povilas Versockas <p.versockas@gmail.com> Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Update lightstep library and add proper error handling lightstep/lightstep-tracer-go#228 introduced a new method to create a Tracer that returns an error when it does not succeed, instead of nil Signed-off-by: Antonio Santos <antonio@santosvelasco.com> * Remove unused import Signed-off-by: Antonio Santos <antonio@santosvelasco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226
I also made error handling consistent for
NewTracer- now it emits event only.Overall I would suggest totally removing the emit event logic. It is not the best idea to have a global logger, especially for the library: it might cause issues if someone wants some flexibility (e.g running two tracers with different loggers.). Anyway, not a blocker for us here (:
Signed-off-by: Bartek Plotka bwplotka@gmail.com