Skip to content

Let assertEquals be strict assertSame #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let assertEquals be strict assertSame #5

wants to merge 1 commit into from

Conversation

peter279k
Copy link
Member

@peter279k peter279k commented Sep 18, 2023 •
edited
Loading

Changed log

  • Let assetEquals be strict assertSame.
  • According the PHPUnit changedlog, it should remove the --verbose option.

peter279k
peter279k commented Sep 18, 2023
View reviewed changes
tests/Linna/Http/Message/UriTest.php
public function testGetPort(string $scheme, string $port, int $expected): void
{
$this->assertEquals($expected, (new Uri("{$scheme}://username:[email protected]{$port}/path?arg=value#anchor"))->getPort());
$this->assertSame($expected, (int)(new Uri("{$scheme}://username:[email protected]{$port}/path?arg=value#anchor"))->getPort());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the data providers, the set#0 and set#4 will return null when calling the Uri::getPort method.

It should casting the null to be 0 when asserting the above two test data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peter279k