Use EnsureConnection() in ConfigurationID property of DataConnection and DataContext #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksk571
requested review from
MaceWindu,
Shane32,
igor-tkachev,
jods4,
sdanyliv and
viceroypenguin
as code owners
viceroypenguin
approved these changes
Mar 21, 2025
Contributor
|
Thanks! I will review it a bit later - I have doubts it makes sense to use connection's connection string at all for id calculation... |
igor-tkachev
approved these changes
Mar 22, 2025
Contributor
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed. |
MaceWindu
added a commit
to linq2db/linq2db.baselines
that referenced
this pull request
Mar 26, 2025
* [Windows / SQLite (specialized tests)] baselines * [Windows / SQL CE] baselines * [Windows / SQL Server 2005] baselines * [Windows / SQLite (both providers)] baselines * [Windows / SQL Server 2016] baselines * [Windows / SQL Server 2008] baselines * [Windows / SQL Server 2012] baselines * [Windows / SQL Server 2014] baselines * [Linux / Firebird 2.5] baselines * [Linux / DB2 LUW 11.5] baselines * [Linux / Firebird 3.0] baselines * [Linux / Informix 14.10] baselines * [Linux / Firebird 4.0] baselines * [Linux / Firebird 5.0] baselines * [Linux / MariaDB 11] baselines * [Linux / ClickHouse MySql] baselines * [Windows / SQL Server 2017] baselines * [Linux / ClickHouse Client] baselines * [Linux / MySQL 9 (both providers)] baselines * [Linux / MySQL 5.7 (both providers)] baselines * [Windows / SQL Server 2019] baselines * [Windows / Access MDB (Jet/ODBC)] baselines * [Windows / Access ACE (OLEDB/ODBC) x86] baselines * [Linux / Oracle 11g XE] baselines * [Linux / Oracle 12c] baselines * [Linux / PostgreSQL 13] baselines * [Windows / SQL Server 2022] baselines * [Linux / Oracle 21c] baselines * [Linux / Oracle 18c] baselines * [Linux / PostgreSQL 14] baselines * [Linux / ClickHouse Octonica] baselines * [Linux / PostgreSQL 15] baselines * [Linux / Oracle 19c] baselines * [Linux / Oracle 23c] baselines * [Linux / PostgreSQL 17] baselines * [Linux / PostgreSQL 16] baselines * [Linux / Sybase ASE 16] baselines * [Windows / SQL Server EXTRAS] baselines * [Linux / SAP HANA 2] baselines --------- Co-authored-by: Azure Pipelines Bot <[email protected]> Co-authored-by: MaceWindu <[email protected]>
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use EnsureConnection(connect: false) in ConfigurationID to obtain connection string. This way connection is not opened synchronously during query generation.
Fixes #4883