Fix argmax call in logreg tutorial docs to include axis=1. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the fix! Apparently, it had been applied in the code itself (code/logistic_sgd.py), but not in the documentation. |
lamblin
added a commit
that referenced
this pull request
Jan 11, 2013
Fix argmax call in logreg tutorial docs to include axis=1.
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Nov 28, 2019
Fix argmax call in logreg tutorial docs to include axis=1.
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Feb 13, 2020
Fix argmax call in logreg tutorial docs to include axis=1. Former-commit-id: 51f3419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one little error in the text, which led to a very subtle bug, that I just a significant amount of time hunting done. In the first code listing on that page, the second to last code line needs to read:
y_pred = T.argmax(p_y_given_x, axis=1)
instead of
y_pred = T.argmax(p_y_given_x)
As far as I understand it, these lines used to be equivalent in a previous version of Theano, but now they are different significantly different. (At first glance, the code appears to run just fine, though.)