fix code signing issue with diff package #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anifest json but ignores it in package hash as it needs to be included in diff package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Push client sdk needs to check signing for diff packages when the code signing is enabled.
#182 simply ignores the
.codepushreleasefile entirely and it results that file not being included in diff packages (as it is not included inmanifest.json).To fix the diff packages code signing issue, this PR keeps
.codepushreleaseinmanifest.jsonwhile skips it in calculating final package hash. Since the.codepushreleasecontents is signature against package hash, it would change each time the package updates therefore being included in each diff package.