Skip to content

Conversation

@0xverin
Copy link
Contributor

@0xverin 0xverin commented Nov 30, 2022

No description provided.

@jingleizhang jingleizhang self-requested a review November 30, 2022 10:12
@Kailai-Wang
Copy link
Collaborator

Possible to merge it into the other PR?
Each CI would take 2h 😂 , after merging into tee-dev, it takes another ~2h, and then sync the codebase to the other PR takes another 2h

@jingleizhang
Copy link
Contributor

jingleizhang commented Nov 30, 2022

There is a bug in ts-tests/tests/register-parachain.ts that makes the scripts/launch-local-binary.sh fail to register parachain, due to the super old version of polkadot-js/api .

We can merge this branch into the other ones, but it eventually have to be merged into the tee-dev.

What do you think @Kailai-Wang ?

@Kailai-Wang
Copy link
Collaborator

There is a bug in ts-tests/tests/register-parachain.ts that makes the scripts/launch-local-binary.sh fail to register parachain, due to the super old version of polkadot-js/api .

We can merge this branch into the other ones, but it eventually have to be merged into the tee-dev.

What do you think @Kailai-Wang ?

Yes please make changes in #1039 directly, otherwise we get too many CI runs in parallel (and they need to be mutually merged..)

@jingleizhang
Copy link
Contributor

Understand, now close this PR. All changes would be included in ts-tests branch.

@jingleizhang jingleizhang deleted the bugfix-ts-tests branch December 19, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants