Fix for "unsafe use of type bool" warning when compiling with MSVC. #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Tests passed ✓, Code: 17112 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
|
geky
reviewed
Feb 3, 2025
geky
reviewed
Feb 3, 2025
amubiera
force-pushed
the
fix-unsafe-use-of-bool
branch
from
7ccfd91 to
152d030
Compare
Collaborator
Tests passed ✓, Code: 17104 B (+0.0%), Stack: 1448 B (+0.0%), Structs: 812 B (+0.0%)
|
Member
|
Looks good here, thanks for creating a PR! Will bring this in on the next patch release. |
geky
approved these changes
Feb 4, 2025
Member
|
Sorry about the delay, will be releasing this shortly. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using negate on a bool causes a warning when compiling with MSVC 19.X: