fix endless loop in dir_compact and nullptr access in lfs_dir_fetchmatch #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> introduce relocateCounter in dir_compact to catch infinite loop when lfs has no free space left anymore -> call lfs_dir_fetchmatch with ftag=-1 in order to set the invalid bit and never let the function match a dir
Mohawi
changed the title
Member
|
Hi @Mohawi, thanks for creating a PR. Sorry it's taken so long for me to get to this. I'm not sure yet the best way to handle for the possible infinite-loops. For now I've split out the null-pointer exception into a separate PR and rebased it onto master: It looks good to me, so I will merge it when I can |
geky
added a commit
that referenced
this pull request
Dec 1, 2019
fix nullptr access in lfs_dir_fetchmatch (#185)
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> introduce relocateCounter in dir_compact to catch infinite loop when
lfs has no free space left anymore
-> call lfs_dir_fetchmatch with ftag=-1 in order to set the invalid bit
and never let the function match a dir
Fixes:
#177
#184