Fix build with -Wundef #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @rojer, thanks for creating a PR. This is a good idea. Hmm, is there a reason for not putting Wundef in the normal build options? |
Contributor
Author
|
well, the idea is to prevent this from happening in the future. |
Member
|
The Makefile is used directly in CI: https://github.com/ARMmbed/littlefs/blob/master/.travis.yml#L18 If we move -Wundef to the Makefile, that just means users will have the warning if they run the tests locally. The only reason -Werror is special is because halting on warnings can be a pain when testing/debugging locally. |
Contributor
Author
|
ok, sorry, i misunderstood. moved to Makefile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of mongoose-os-libs/vfs-fs-lfs#2