Update SPEC.md #356
Merged
Update SPEC.md #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
reviewed
Dec 19, 2019
SPEC.md
Outdated
| tag data | ||
| [-- 32 --][-- 32 --|--- variable length ---] | ||
| [1| 3| 8 | 10 | 10 ][-- 32 --|--- (size) ---] | ||
| [1| 3| 8 | 10 | 10 ][-- 32 --|--- (size - 4) ---] |
Member
There was a problem hiding this comment.
Should this actually be (size - 32) since the other fields are in bits?
Contributor
Author
There was a problem hiding this comment.
yes, this field should in bits, but size is in bytes, maybe (size * 8 - 32) is better ?
Member
There was a problem hiding this comment.
Ah! Good point, you're right that is better.
| [1| 3| 8 | 10 | 10 ][-- 32 --|--- (size) ---] | ||
| [1| 3| 8 | 10 | 10 ][-- 32 --|--- (size - 4) ---] | ||
| ^ ^ ^ ^ ^ ^- crc ^- padding | ||
| | | | | '- size (12) |
Member
There was a problem hiding this comment.
What does this 12 mean here? The size could be any value.
zqb-all
force-pushed
the
patch-1
branch
2 times, most recently
from
e10636c to
7fec59a
Compare
Member
|
Hi @zqb-all, sorry about the absence. Does the updated comment make sense to you? If you're not able to update the PR I can bring it in and make the suggested changes on the next release. |
1.fix size in Layout of the CRC tag 2.update (size) to (size * 8)
Contributor
Author
|
Hi @geky, thanks for you reply, I am glad to update the PR. |
geky
approved these changes
Mar 30, 2020
Member
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix size in Layout of the CRC tag