Skip to content

Add LFS_READONLY define, to allow smaller builds providing read-only mode #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geky merged 10 commits into from
Dec 4, 2020
+177 −6
Merged

Add LFS_READONLY define, to allow smaller builds providing read-only mode #480

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8e6826c
Add LFS_READYONLY define, to allow smaller builds providing read-only…
maximevince Oct 28, 2020
46b5033
LFS_READONLY: undef unavailable function declarations altogether
maximevince Nov 17, 2020
882aae5
LFS_READONLY: even less code, assert on write attempts
maximevince Nov 19, 2020
69da107
LFS_READONLY: remove LFS_O_WRONLY and other flags when compiling with…
maximevince Nov 20, 2020
0360629
LFS_READONLY: do not annotate #endif, as requested
maximevince Nov 21, 2020
83fd2e8
LFS_READONLY: move ifdef before comments blocks, rework dangling open…
maximevince Nov 21, 2020
35cc31e
LFS_READONLY: ifdef file flags that are not needed in read-only mode
maximevince Nov 21, 2020
94c9c4c
LFS_READONLY: slight refactor
maximevince Nov 21, 2020
5c4e375
Added read-only build+size reporting to CI
geky Nov 22, 2020
99c960b
LFS_READONLY: ifdef LFS_F_ERRED out as well
maximevince Nov 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LFS_READONLY: slight refactor
  • Loading branch information
@maximevince
maximevince committed Nov 21, 2020
commit 94c9c4c0404f95a75fdca91d0201d2785adab1cb
13 changes: 6 additions & 7 deletions lfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2469,11 +2469,12 @@ int lfs_file_opencfg(lfs_t *lfs, lfs_file_t *file,
file->next = (lfs_file_t*)lfs->mlist;
lfs->mlist = (struct lfs_mlist*)file;

if (tag == LFS_ERR_NOENT) {
#ifdef LFS_READONLY
if (tag == LFS_ERR_NOENT) {
err = LFS_ERR_NOENT;
goto cleanup;
#else
if (tag == LFS_ERR_NOENT) {
if (!(flags & LFS_O_CREAT)) {
err = LFS_ERR_NOENT;
goto cleanup;
Expand Down Expand Up @@ -2871,7 +2872,7 @@ lfs_ssize_t lfs_file_read(lfs_t *lfs, lfs_file_t *file,
(void*)lfs, (void*)file, buffer, size);
LFS_ASSERT(file->flags & LFS_F_OPENED);
#ifdef LFS_READONLY
/* always LFS_O_RDONLY */
// always LFS_O_RDONLY
#else
LFS_ASSERT((file->flags & 3) != LFS_O_WRONLY);
#endif
Expand Down Expand Up @@ -3217,12 +3218,10 @@ lfs_soff_t lfs_file_size(lfs_t *lfs, lfs_file_t *file) {
LFS_TRACE("lfs_file_size -> %"PRId32,
lfs_max(file->pos, file->ctz.size));
return lfs_max(file->pos, file->ctz.size);
} else
#endif
{
LFS_TRACE("lfs_file_size -> %"PRId32, file->ctz.size);
return file->ctz.size;
}
#endif
LFS_TRACE("lfs_file_size -> %"PRId32, file->ctz.size);
return file->ctz.size;
}


Expand Down