Skip to content

Fix several wear-leveling issues found in lfs_alloc_reset #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geky merged 5 commits into from
Dec 4, 2020
Merged

Fix several wear-leveling issues found in lfs_alloc_reset #487

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
480cdd9
Fixed incorrect modulus in lfs_alloc_reset
geky Nov 14, 2020
1ae4b36
Removed unnecessary randomization of offsets in lfs_alloc_reset
geky Nov 20, 2020
f215027
Switched to CRC as seed collection function instead of xor
geky Nov 20, 2020
0ea2871
Fixed typo in scripts/readtree.py
geky Nov 22, 2020
0aba71d
Fixed single unchecked bit during commit verification
geky Nov 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed incorrect modulus in lfs_alloc_reset 
Modulus of the offset by block_size was clearly a typo, and should be
block_count. Interesting to note that later moduluses during alloc
calculations prevents this from breaking anything, but as gtaska notes it
could skew the wear-leveling distribution.

Found by guiserle and gtaska
  • Loading branch information
@geky
geky committed Nov 20, 2020
commit 480cdd9f815d1d78caf98f22ed94ef4f58e46d0c
2 changes: 1 addition & 1 deletion lfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ static void lfs_alloc_ack(lfs_t *lfs) {
// Invalidate the lookahead buffer. This is done during mounting and
// failed traversals
static void lfs_alloc_reset(lfs_t *lfs) {
lfs->free.off = lfs->seed % lfs->cfg->block_size;
lfs->free.off = lfs->seed % lfs->cfg->block_count;
lfs->free.size = 0;
lfs->free.i = 0;
lfs_alloc_ack(lfs);
Expand Down