Fix staticcheck issues and add staticcheck to ci#263
Merged
Conversation
ralfiannor
added a commit
to ralfiannor/bud
that referenced
this pull request
Aug 29, 2022
Fix staticcheck issues and add staticcheck to ci (livebud#263)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since my IDE has staticcheck built-in I would occasionally fix issues in the specific files, but this PR fixes the existing staticcheck issues and now runs staticcheck in CI and reports any issues across the entire codebase.