Skip to content

[CIR][CIRGen] Convert trivial copy constructor and assignment operator calls to memcpy #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcardosolopes merged 13 commits into from
Jun 26, 2025
Merged

[CIR][CIRGen] Convert trivial copy constructor and assignment operator calls to memcpy #1677

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eda592b
Implement trivial constructor call lowering in LoweringPreparePass
Arthur-Chang016 Jun 12, 2025
3b20b32
Add test for trivial copy in CIR code generation
Arthur-Chang016 Jun 12, 2025
e1fdaea
Update testcase behavior
Arthur-Chang016 Jun 12, 2025
56373b9
Update coroutine task check from copy assignment to cir.copy operatio…
Arthur-Chang016 Jun 12, 2025
997d956
Update CIR test to reflect changes in copy constructor handling
Arthur-Chang016 Jun 12, 2025
1ea83c9
Mark as expectedly failed. Update some trivial ctor behavior
Arthur-Chang016 Jun 12, 2025
901146e
Update trivial ctor to cir.copy
Arthur-Chang016 Jun 12, 2025
99b1738
Update CIR test to reflect changes in trivial copy ctor
Arthur-Chang016 May 28, 2025
2c7db5b
Update constructor call in foo function to use cir.copy operation
Arthur-Chang016 Jun 12, 2025
760a781
Replace constructor call with cir.copy operation for better clarity i…
Arthur-Chang016 Jun 12, 2025
fe0cba9
Clean code
Arthur-Chang016 Jun 12, 2025
a3314db
Refactor to be more clearly
Arthur-Chang016 Jun 12, 2025
9886b4d
Refactor lowerTrivialConstructorCall to remove unnecessary comments a…
Arthur-Chang016 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CIR test to reflect changes in copy constructor handling 
 - Modified the expected output in derived-to-base.cpp to replace the copy constructor call with a direct cir.copy operation
 - Replace call operations with cir.copy for buffy and A class instances in vcall function
  • Loading branch information
@Arthur-Chang016
Arthur-Chang016 committed Jun 12, 2025
commit 997d956614054d4c26f472c17d8ae2310f4e915d
4 changes: 2 additions & 2 deletions clang/test/CIR/CodeGen/derived-to-base.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void vcall(C1 &c1) {
// CHECK: cir.store %arg0, %0 : !cir.ptr<!rec_C1>, !cir.ptr<!cir.ptr<!rec_C1>>
// CHECK: %4 = cir.load{{.*}} %0 : !cir.ptr<!cir.ptr<!rec_C1>>, !cir.ptr<!rec_C1>
// CHECK: %5 = cir.load{{.*}} %2 : !cir.ptr<!s32i>, !s32i
// CHECK: cir.call @_ZN5buffyC2ERKS_(%3, %1) : (!cir.ptr<!rec_buffy>, !cir.ptr<!rec_buffy>) -> ()
// CHECK: cir.copy %1 to %3 : !cir.ptr<!rec_buffy>
// CHECK: %6 = cir.load{{.*}} %3 : !cir.ptr<!rec_buffy>, !rec_buffy
// CHECK: %7 = cir.cast(bitcast, %4 : !cir.ptr<!rec_C1>), !cir.ptr<!cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_C1>, !s32i, !rec_buffy) -> !s32i>>>>
// CHECK: %8 = cir.load{{.*}} %7 : !cir.ptr<!cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_C1>, !s32i, !rec_buffy) -> !s32i>>>>, !cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_C1>, !s32i, !rec_buffy) -> !s32i>>>
Expand Down Expand Up @@ -147,7 +147,7 @@ class B : public A {
// CHECK: %3 = cir.base_class_addr %1 : !cir.ptr<!rec_B> nonnull [0] -> !cir.ptr<!rec_A>

// Call @A::A(A const&)
// CHECK: cir.call @_ZN1AC2ERKS_(%2, %3) : (!cir.ptr<!rec_A>, !cir.ptr<!rec_A>) -> ()
// CHECK: cir.copy %3 to %2 : !cir.ptr<!rec_A>

// Call @A::foo()
// CHECK: cir.call @_ZN1A3fooEv(%2) : (!cir.ptr<!rec_A>) -> ()
Expand Down