Skip to content

[ThroughMLIR] basic printf support #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcardosolopes merged 4 commits into from
Jun 17, 2025
Merged

[ThroughMLIR] basic printf support #1687

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88570c4
[ThroughMLIR] implementated printf support for cir.func lowering + ad…
felixdaas Jun 7, 2025
dc9baf7
[ThroughMLIR] Implemented special hadling of printf in cir.call lower…
felixdaas Jun 8, 2025
dd36dd4
some cleanup + improved comments
felixdaas Jun 9, 2025
2d9555b
Added a testcase for the adjusted cir.func/cir.call lowering for the …
felixdaas Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added a testcase for the adjusted cir.func/cir.call lowering for the … 
…printf special case
  • Loading branch information
@felixdaas
felixdaas committed Jun 15, 2025
commit 2d9555b9ca160666a99287e2299232612341dbce
38 changes: 38 additions & 0 deletions clang/test/CIR/Lowering/ThroughMLIR/call.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,41 @@ int test(void) {
// CHECK: %[[ARG:.+]] = arith.constant 2 : i32
// CHECK-NEXT: call @foo(%[[ARG]]) : (i32) -> ()
// CHECK: }

extern int printf(const char *str, ...);

// CHECK-LABEL: llvm.func @printf(!llvm.ptr, ...) -> i32
// CHECK: llvm.mlir.global internal constant @[[FRMT_STR:.*]](dense<[37, 100, 44, 32, 37, 102, 44, 32, 37, 100, 44, 32, 37, 108, 108, 100, 44, 32, 37, 100, 44, 32, 37, 102, 10, 0]> : tensor<26xi8>) {addr_space = 0 : i32} : !llvm.array<26 x i8>

void testfunc(short s, float X, char C, long long LL, int I, double D) {
printf("%d, %f, %d, %lld, %d, %f\n", s, X, C, LL, I, D);
}

// CHECK: func.func @testfunc(%[[ARG0:.*]]: i16 {{.*}}, %[[ARG1:.*]]: f32 {{.*}}, %[[ARG2:.*]]: i8 {{.*}}, %[[ARG3:.*]]: i64 {{.*}}, %[[ARG4:.*]]: i32 {{.*}}, %[[ARG5:.*]]: f64 {{.*}}) {
// CHECK: %[[ALLOCA_S:.*]] = memref.alloca() {alignment = 2 : i64} : memref<i16>
// CHECK: %[[ALLOCA_X:.*]] = memref.alloca() {alignment = 4 : i64} : memref<f32>
// CHECK: %[[ALLOCA_C:.*]] = memref.alloca() {alignment = 1 : i64} : memref<i8>
// CHECK: %[[ALLOCA_LL:.*]] = memref.alloca() {alignment = 8 : i64} : memref<i64>
// CHECK: %[[ALLOCA_I:.*]] = memref.alloca() {alignment = 4 : i64} : memref<i32>
// CHECK: %[[ALLOCA_D:.*]] = memref.alloca() {alignment = 8 : i64} : memref<f64>
// CHECK: memref.store %[[ARG0]], %[[ALLOCA_S]][] : memref<i16>
// CHECK: memref.store %[[ARG1]], %[[ALLOCA_X]][] : memref<f32>
// CHECK: memref.store %[[ARG2]], %[[ALLOCA_C]][] : memref<i8>
// CHECK: memref.store %[[ARG3]], %[[ALLOCA_LL]][] : memref<i64>
// CHECK: memref.store %[[ARG4]], %[[ALLOCA_I]][] : memref<i32>
// CHECK: memref.store %[[ARG5]], %[[ALLOCA_D]][] : memref<f64>
// CHECK: %[[FRMT_STR_ADDR:.*]] = llvm.mlir.addressof @[[FRMT_STR]] : !llvm.ptr
// CHECK: %[[C0:.*]] = llvm.mlir.constant(0 : index) : i8
// CHECK: %[[FRMT_STR_DATA:.*]] = llvm.getelementptr %[[FRMT_STR_ADDR]][%[[C0]], %[[C0]]] : (!llvm.ptr, i8, i8) -> !llvm.ptr, !llvm.array<26 x i8>
// CHECK: %[[S:.*]] = memref.load %[[ALLOCA_S]][] : memref<i16>
// CHECK: %[[S_EXT:.*]] = arith.extsi %3 : i16 to i32
// CHECK: %[[X:.*]] = memref.load %[[ALLOCA_X]][] : memref<f32>
// CHECK: %[[X_EXT:.*]] = arith.extf %5 : f32 to f64
// CHECK: %[[C:.*]] = memref.load %[[ALLOCA_C]][] : memref<i8>
// CHECK: %[[C_EXT:.*]] = arith.extsi %7 : i8 to i32
// CHECK: %[[LL:.*]] = memref.load %[[ALLOCA_LL]][] : memref<i64>
// CHECK: %[[I:.*]] = memref.load %[[ALLOCA_I]][] : memref<i32>
// CHECK: %[[D:.*]] = memref.load %[[ALLOCA_D]][] : memref<f64>
// CHECK: {{.*}} = llvm.call @printf(%[[FRMT_STR_DATA]], %[[S_EXT]], %[[X_EXT]], %[[C_EXT]], %[[LL]], %[[I]], %[[D]]) vararg(!llvm.func<i32 (ptr, ...)>) : (!llvm.ptr, i32, f64, i32, i64, i32, f64) -> i32
// CHECK: return
// CHECK: }
Loading