Skip to content

[clang-repl] Names declared in if conditions and for-init statements are local to the inner context (C++ 3.3.2p4) #84150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weliveindetail merged 9 commits into from
Mar 7, 2024
Merged

[clang-repl] Names declared in if conditions and for-init statements are local to the inner context (C++ 3.3.2p4) #84150

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
27ff0dd
Add test cases for variable definitions inside for-init and condition…
weliveindetail Feb 28, 2024
b97605a
Try to fix llvm/llvm-project#83028
vgvassilev Mar 4, 2024
ff26b12
fixup! Try to fix llvm/llvm-project#83028
weliveindetail Mar 5, 2024
5aa374d
fixup! Try to fix llvm/llvm-project#83028
weliveindetail Mar 6, 2024
83265cf
fixup! Try to fix llvm/llvm-project#83028
weliveindetail Mar 5, 2024
27341ab
fixup! Try to fix llvm/llvm-project#83028
weliveindetail Mar 6, 2024
68ed18f
Test cases for variable definitions inside for-init and condition sta…
weliveindetail Mar 6, 2024
7b7cd67
Refine test execute-stmts.cpp
weliveindetail Mar 6, 2024
4f32884
Add test-case for variable definition in range-based for-loop
weliveindetail Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Try to fix #83028 
Add TopLevelStmtDecl to outer DeclContext (and push new scopes afterwards)
  • Loading branch information
@weliveindetail
weliveindetail committed Mar 6, 2024
commit 27341ab72c084ee0264ea5bbee025ff8c4d313d5
5 changes: 3 additions & 2 deletions clang/lib/Sema/SemaDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20521,17 +20521,18 @@ Decl *Sema::ActOnFileScopeAsmDecl(Expr *expr,

TopLevelStmtDecl *Sema::ActOnStartTopLevelStmtDecl(Scope *S) {
auto *New = TopLevelStmtDecl::Create(Context, /*Statement=*/nullptr);
CurContext->addDecl(New);
PushDeclContext(S, New);
PushFunctionScope();
PushCompoundScope(false);
PushDeclContext(S, New);
return New;
}

void Sema::ActOnFinishTopLevelStmtDecl(TopLevelStmtDecl *D, Stmt *Statement) {
D->setStmt(Statement);
PopDeclContext();
PopCompoundScope();
PopFunctionScopeInfo();
PopDeclContext();
}

void Sema::ActOnPragmaRedefineExtname(IdentifierInfo* Name,
Expand Down