Skip to content

[lldb] Fix typo in CumulativeSystemTimeIsValid check #89680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[lldb] Fix typo in CumulativeSystemTimeIsValid check #89680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efa8050
[lldb] Fix typo in CumulativeSystemTimeIsValid check
marcauberer Apr 22, 2024
c028b10
Add tests for Cumulative[User|System]TimeIsValid
marcauberer Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/include/lldb/Utility/ProcessInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class ProcessInstanceInfo : public ProcessInfo {

bool CumulativeSystemTimeIsValid() const {
return m_cumulative_system_time.tv_sec > 0 ||
m_cumulative_system_time.tv_sec > 0;
m_cumulative_system_time.tv_usec > 0;
}

void Dump(Stream &s, UserIDResolver &resolver) const;
Expand Down
21 changes: 21 additions & 0 deletions lldb/unittests/Host/HostTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//

#include "lldb/Host/Host.h"
#include "lldb/Utility/ProcessInfo.h"
#include "gtest/gtest.h"

using namespace lldb_private;
Expand All @@ -25,3 +26,23 @@ TEST(Host, GetEnvironment) {
ASSERT_EQ("Host::GetEnvironment",
Host::GetEnvironment().lookup("LLDB_TEST_ENVIRONMENT_VAR"));
}

TEST(Host, ProcessInstanceInfoCumulativeUserTimeIsValid) {
ProcessInstanceInfo info;
info.SetCumulativeUserTime(ProcessInstanceInfo::timespec{0, 0});
EXPECT_FALSE(info.CumulativeUserTimeIsValid());
info.SetCumulativeUserTime(ProcessInstanceInfo::timespec{0, 1});
EXPECT_TRUE(info.CumulativeUserTimeIsValid());
info.SetCumulativeUserTime(ProcessInstanceInfo::timespec{1, 0});
EXPECT_TRUE(info.CumulativeUserTimeIsValid());
}

TEST(Host, ProcessInstanceInfoCumulativeSystemTimeIsValid) {
ProcessInstanceInfo info;
info.SetCumulativeSystemTime(ProcessInstanceInfo::timespec{0, 0});
EXPECT_FALSE(info.CumulativeSystemTimeIsValid());
info.SetCumulativeSystemTime(ProcessInstanceInfo::timespec{0, 1});
EXPECT_TRUE(info.CumulativeSystemTimeIsValid());
info.SetCumulativeSystemTime(ProcessInstanceInfo::timespec{1, 0});
EXPECT_TRUE(info.CumulativeSystemTimeIsValid());
}