Skip to content

Conversation

@wangzhen263
Copy link
Contributor

@wangzhen263 wangzhen263 commented Aug 26, 2023

Why are these changes needed?

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).


def match(self, model_path: str):
return "flan" in model_path.lower()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the instruction template for flan? Do we need to set it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @merrymercy, do you mean prompt template?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangzhen263 Any updates? IIRC, flan-t5 has a default prompt template.

@merrymercy merrymercy force-pushed the main branch 2 times, most recently from bf7aa7e to a81a04c Compare August 28, 2023 01:36
@merrymercy
Copy link
Member

Closed due to inactivity. Feel free to reopen after you address these problems.

  1. Use the correct prompt templates for Flan-T5
  2. Format your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants