Skip to content

Fix Salesforce xgen inference #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 3 commits into from
Sep 18, 2023
Merged

Fix Salesforce xgen inference #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60b71e6
Fix xgen inference
jaywonchung Sep 4, 2023
d9cb753
Update fastchat/conversation.py
jaywonchung Sep 18, 2023
d85c929
Merge branch 'lm-sys:main' into main
jaywonchung Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions fastchat/conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,11 +754,10 @@ def get_conv_template(name: str) -> Conversation:
Conversation(
name="xgen",
system_message="A chat between a curious human and an artificial intelligence assistant. The assistant gives helpful, detailed, and polite answers to the human's questions.\n\n",
roles=("### Human: ", "###"),
sep_style=SeparatorStyle.NO_COLON_SINGLE,
roles=("### Human", "### Assistant"),
sep_style=SeparatorStyle.ADD_COLON_SINGLE,
sep="\n",
stop_token_ids=[50256, 0, 1, 2],
stop_str="<|endoftext|>",
stop_token_ids=[50256],
)
)

Expand Down
3 changes: 2 additions & 1 deletion fastchat/serve/inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def generate_stream(
echo = bool(params.get("echo", True))
stop_str = params.get("stop", None)
stop_token_ids = params.get("stop_token_ids", None) or []
stop_token_ids.append(tokenizer.eos_token_id)
if tokenizer.eos_token_id not in stop_token_ids:
stop_token_ids.append(tokenizer.eos_token_id)

logits_processor = prepare_logits_processor(
temperature, repetition_penalty, top_p, top_k
Expand Down