Skip to content

Use fsdp api for safe save #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 3 commits into from
Sep 10, 2023
Merged

Use fsdp api for safe save #2390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a5bd59
use fsdp api for save save
merrymercy Sep 10, 2023
c6bdb39
fix
merrymercy Sep 10, 2023
464725f
format
merrymercy Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions fastchat/train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,15 @@ def rank0_print(*args):
print(*args)


def safe_save_model_for_hf_trainer(trainer: transformers.Trainer, output_dir: str):
"""Collects the state dict and dump to disk."""
state_dict = trainer.model.state_dict()
if trainer.args.should_save:
cpu_state_dict = {key: value.cpu() for key, value in state_dict.items()}
del state_dict
trainer._save(output_dir, state_dict=cpu_state_dict) # noqa
def trainer_save_model_safe(trainer: transformers.Trainer):
from torch.distributed.fsdp import FullyShardedDataParallel as FSDP
from torch.distributed.fsdp import StateDictType, FullStateDictConfig

save_policy = FullStateDictConfig(offload_to_cpu=True, rank0_only=True)
with FSDP.state_dict_type(
trainer.model, StateDictType.FULL_STATE_DICT, save_policy
):
trainer.save_model()


def preprocess(
Expand Down Expand Up @@ -279,9 +281,11 @@ def train():
trainer.train(resume_from_checkpoint=True)
else:
trainer.train()

# Save model
model.config.use_cache = True
trainer.save_state()
safe_save_model_for_hf_trainer(trainer=trainer, output_dir=training_args.output_dir)
trainer_save_model_safe(trainer)


if __name__ == "__main__":
Expand Down