Skip to content

Fix falcon chat template #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 1 commit into from
Sep 22, 2023
Merged

Fix falcon chat template #2464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix falcon chat template
  • Loading branch information
@merrymercy
merrymercy committed Sep 22, 2023
commit 0579cf0c63c8acda2e6c44d68c0f869a00802c06
5 changes: 3 additions & 2 deletions fastchat/conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,12 @@ def get_prompt(self) -> str:
elif self.sep_style == SeparatorStyle.FALCON_CHAT:
ret = ""
if self.system_message:
ret += "System: " + self.system_message + self.sep
ret += system_prompt + self.sep
for role, message in self.messages:
if message:
ret += role + ": " + message + self.sep
else:
ret += role + ": "
ret += role + ":"

return ret
else:
Expand Down Expand Up @@ -958,6 +958,7 @@ def get_conv_template(name: str) -> Conversation:
Conversation(
name="falcon-chat",
roles=("User", "Falcon"),
system_template="System: {system_message}",
messages=[],
sep_style=SeparatorStyle.FALCON_CHAT,
sep="\n",
Expand Down