Skip to content

fix: Fix for OpenOrcaAdapter to return correct conversation template #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 3 commits into from
Nov 2, 2023
Merged

fix: Fix for OpenOrcaAdapter to return correct conversation template #2613

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11bc739
fix: Fix for OpenOrcaAdapter to return correct conversation template
vjsrinath Oct 30, 2023
b3d04d1
Update model_adapter.py
vjsrinath Oct 30, 2023
5389c07
fix: fixed match method to return boolean if the model_path is found …
vjsrinath Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions fastchat/model/model_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,12 +1362,10 @@ class OpenOrcaAdapter(BaseModelAdapter):
use_fast_tokenizer = False

def match(self, model_path: str):
if "mistral-7b-openorca" in model_path.lower():
return get_conv_template("mistral-7b-openorca")
elif "openorca" in model_path.lower():
return get_conv_template("open-orca")
else:
return False
return (
"mistral-7b-openorca" in model_path.lower()
or "openorca" in model_path.lower()
)

def load_model(self, model_path: str, from_pretrained_kwargs: dict):
revision = from_pretrained_kwargs.get("revision", "main")
Expand All @@ -1382,6 +1380,8 @@ def load_model(self, model_path: str, from_pretrained_kwargs: dict):
return model, tokenizer

def get_default_conv_template(self, model_path: str) -> Conversation:
if "mistral-7b-openorca" in model_path.lower():
return get_conv_template("mistral-7b-openorca")
Copy link
Member

@merrymercy merrymercy Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In function def match(self, model_path: str):, it should return "True/Flase" instead of get_conv_template.
Could you fix it?

Copy link
Contributor Author

@vjsrinath vjsrinath Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I will fix that in a bit.

Copy link
Contributor Author

@vjsrinath vjsrinath Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merrymercy Required changes have been made and pushed.

return get_conv_template("open-orca")


Expand Down Expand Up @@ -1770,9 +1770,9 @@ def get_default_conv_template(self, model_path: str) -> Conversation:
register_model_adapter(InternLMChatAdapter)
register_model_adapter(StarChatAdapter)
register_model_adapter(Llama2Adapter)
register_model_adapter(MistralAdapter)
register_model_adapter(CuteGPTAdapter)
register_model_adapter(OpenOrcaAdapter)
register_model_adapter(MistralAdapter)
register_model_adapter(WizardCoderAdapter)
register_model_adapter(QwenChatAdapter)
register_model_adapter(AquilaChatAdapter)
Expand Down