Skip to content

Add required_temp support in jsonl format to support flexible temperature setting for gen_api_answer #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
infwinston merged 6 commits into from
Nov 8, 2023
Merged

Add required_temp support in jsonl format to support flexible temperature setting for gen_api_answer #2653

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd19588
add required_temp to gen_api_answer to support flexible temperature s…
CodingWithTim Nov 8, 2023
15158c9
update gen_api_answer.py
CodingWithTim Nov 8, 2023
40bc583
change name
CodingWithTim Nov 8, 2023
2281acd
fix name
CodingWithTim Nov 8, 2023
17f63ed
add assertion
CodingWithTim Nov 8, 2023
d6dda01
fix format
CodingWithTim Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fastchat/llm_judge/gen_api_answer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@
def get_answer(
question: dict, model: str, num_choices: int, max_tokens: int, answer_file: str
):
Copy link
Member

@infwinston infwinston Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add an assertion that we can't have both args.force_temperature and required_temperature

Copy link
Collaborator Author

@CodingWithTim CodingWithTim Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added an assertion to make sure both can't be true.

assert (
args.force_temperature is not None and "required_temperature" in question.keys()
) == False
if args.force_temperature is not None:
temperature = args.force_temperature
elif "required_temperature" in question.keys():
temperature = question["required_temperature"]
elif question["category"] in temperature_config:
temperature = temperature_config[question["category"]]
else:
Expand Down