Skip to content

Remove exclude_unset parameter #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 1 commit into from
Nov 9, 2023
Merged

Remove exclude_unset parameter #2654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove exclude_unset parameter to keep default "object" and "created"… 
…. They are required in OpenAI docs and some SDK
  • Loading branch information
@snapshotpl
snapshotpl committed Nov 8, 2023
commit 7ecbf71b2ae664f79f4c914e81de45f86c005df3
8 changes: 4 additions & 4 deletions fastchat/serve/openai_api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ async def chat_completion_stream_generator(
chunk = ChatCompletionStreamResponse(
id=id, choices=[choice_data], model=model_name
)
yield f"data: {chunk.json(exclude_unset=True, ensure_ascii=False)}\n\n"
yield f"data: {chunk.json(ensure_ascii=False)}\n\n"

previous_text = ""
async for content in generate_completion_stream(gen_params, worker_addr):
Expand Down Expand Up @@ -482,7 +482,7 @@ async def chat_completion_stream_generator(
if content.get("finish_reason", None) is not None:
finish_stream_events.append(chunk)
continue
yield f"data: {chunk.json(exclude_unset=True, ensure_ascii=False)}\n\n"
yield f"data: {chunk.json(ensure_ascii=False)}\n\n"
# There is not "content" field in the last delta message, so exclude_none to exclude field "content".
for finish_chunk in finish_stream_events:
yield f"data: {finish_chunk.json(exclude_none=True, ensure_ascii=False)}\n\n"
Expand Down Expand Up @@ -615,10 +615,10 @@ async def generate_completion_stream_generator(
if content.get("finish_reason", None) is not None:
finish_stream_events.append(chunk)
continue
yield f"data: {chunk.json(exclude_unset=True, ensure_ascii=False)}\n\n"
yield f"data: {chunk.json(ensure_ascii=False)}\n\n"
# There is not "content" field in the last delta message, so exclude_none to exclude field "content".
for finish_chunk in finish_stream_events:
yield f"data: {finish_chunk.json(exclude_unset=True, ensure_ascii=False)}\n\n"
yield f"data: {finish_chunk.json(exclude_none=True, ensure_ascii=False)}\n\n"
yield "data: [DONE]\n\n"


Expand Down