Skip to content

Fix Hermes2Adapter #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 2 commits into from
Nov 26, 2023
Merged

Fix Hermes2Adapter #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c401172
Fix Hermes2Adapter
lewtun Nov 23, 2023
9606d78
Revert
lewtun Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fastchat/model/model_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,9 +1481,9 @@ class Hermes2Adapter(BaseModelAdapter):
use_fast_tokenizer = False

def match(self, model_path: str):
return (
"openhermes-2.5-mistral-7b"
or "openhermes-2-mistral-7b" in model_path.lower()
return any(
model_str in model_path.lower()
for model_str in ["openhermes-2.5-mistral-7b", "openhermes-2-mistral-7b"]
)

def load_model(self, model_path: str, from_pretrained_kwargs: dict):
Expand Down