Skip to content

Fix YiAdapter #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 3 commits into from
Nov 26, 2023
Merged

Fix YiAdapter #2730

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a37e93
Fix YiAdapter
Jingsong-Yan Nov 24, 2023
c51fc1e
Update fastchat/model/model_adapter.py
merrymercy Nov 26, 2023
695f598
Apply suggestions from code review
merrymercy Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@merrymercy
merrymercy authored Nov 26, 2023
commit 695f5988118ccbcaf12d1c013c28ea9d8e96d7e4
1 change: 0 additions & 1 deletion fastchat/model/model_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,7 +1916,6 @@ class YiAdapter(BaseModelAdapter):
"""The model adapter for Yi models"""

def match(self, model_path: str):
# use "yi-" instead of "yi" to support Yi Series Models, because "yi" is usually a sub-string of certain words.
return "yi-" in model_path.lower() and "chat" in model_path.lower()

def get_default_conv_template(self, model_path: str) -> Conversation:
Expand Down