Update standardrb for Ruby 3.4 #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for spotting this. Unfortunately, the GitHub PR workflow is undergoing some changes so I think you'll have to click 'ready for review' for the workflow to run. |
caius
force-pushed
the
cd/standardrb-ruby-3.4
branch
from
f03ece2 to
6355a10
Compare
Contributor
Author
|
Rebased after #1418 landed too. All seems good thankfully 😁 |
These will include any changes required for Ruby 3.4
We only call them through the `standardrb` binary from the cli, no need to load them into the app runtime.
caius
force-pushed
the
cd/standardrb-ruby-3.4
branch
from
6355a10 to
fc3881e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
/dev/nullwith ruby constantWhy?
Updates all the standard gems (and dependencies) we have included so they know how to handle Ruby 3.4 and suggest 3.4+ "fixes" we should adhere to.
We also don't need to issue
require "standard", etc when the app boots - we don't make use of the gems in the app itself. Setting them torequire: falsein the Gemfile achieves this. They are all still available to call as cli tools, sobundle exec standardrbworks identically.