Skip to content

improve port binding using environment variables #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

improve port binding using environment variables #37

merged 1 commit into from
Feb 3, 2021

Conversation

Madh93
Copy link
Contributor

@Madh93 Madh93 commented Feb 2, 2021

Hi,

This is an improvement of #33 that allows to use environment variables.

Changes

  • Support LOCALSTACK_EDGE_PORT and LOCALSTACK_ELASTICSEARCH_PORT to configure port binding

@whummer
Copy link
Member

whummer commented Feb 3, 2021

Looks great, thanks for this PR @Madh93 👍

@whummer whummer merged commit bc71a33 into localstack:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Madh93 @whummer