Skip to content

Update LoggingEventJsonPatternParser to fix breaking logback change #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update LoggingEventJsonPatternParser to fix breaking logback change #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ from the maven repository exist on the runtime classpath.
Specifically, the following need to be available on the runtime classpath:

* jackson-databind / jackson-core / jackson-annotations >= 2.17.0
* logback-core >= 1.5.0
* logback-classic >= 1.5.0 (required for logging _LoggingEvents_)
* logback-access >= 2.0.0 (required for logging _AccessEvents_)
* logback-core >= 1.5.18
* logback-classic >= 1.5.18 (required for logging _LoggingEvents_)
* logback-access >= 2.0.6 (required for logging _AccessEvents_)
* slf4j-api (usually comes as a transitive dependency of logback-classic)
* java-uuid-generator (required if the `uuid` provider is used)

Expand Down
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
<!-- runtime dependencies -->
<jackson.version>2.17.2</jackson.version>
<java-uuid-generator.version>5.1.0</java-uuid-generator.version>
<logback-core.version>1.5.6</logback-core.version>
<logback-access.version>2.0.2</logback-access.version>
<logback-core.version>1.5.18</logback-core.version>
<logback-access.version>2.0.6</logback-access.version>

<!-- shaded runtime dependencies -->
<disruptor.version>3.4.4</disruptor.version>
Expand Down Expand Up @@ -155,7 +155,7 @@
</dependency>
<dependency>
<groupId>ch.qos.logback.access</groupId>
<artifactId>common</artifactId>
<artifactId>logback-access-common</artifactId>
<version>${logback-access.version}</version>
<!--
Required for logging IAccessEvents for access logs.
Expand Down Expand Up @@ -545,7 +545,7 @@
<links>
<link>https://javadoc.io/doc/ch.qos.logback/logback-core/${logback-core.version}</link>
<link>https://javadoc.io/doc/ch.qos.logback/logback-classic/${logback-core.version}</link>
<link>https://javadoc.io/doc/ch.qos.logback.access/common/${logback-access.version}</link>
<link>https://javadoc.io/doc/ch.qos.logback.access/logback-access-common/${logback-access.version}</link>

<link>https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/${jackson.version}</link>
<link>https://javadoc.io/doc/com.fasterxml.jackson.core/jackson-databind/${jackson.version}</link>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/logstash/logback/pattern/LoggingEventJsonPatternParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public LoggingEventJsonPatternParser(final Context context, final JsonFactory js
@Override
protected PatternLayoutBase<ILoggingEvent> createLayout() {
PatternLayoutBase<ILoggingEvent> layout = new PatternLayout();
layout.getInstanceConverterMap().put("property", EnhancedPropertyConverter.class.getName());
layout.getInstanceConverterMap().put("property", EnhancedPropertyConverter::new);
return layout;
}

Expand Down