Skip to content

Avoid calling 'toArray' with pre-sized array argument #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Avoid calling 'toArray' with pre-sized array argument #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bca071
Avoid calling 'toArray' with pre-sized array argument
Apr 4, 2021
7bd5243
Avoid calling 'toArray' with pre-sized array argument
Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,7 @@ public void addDestination(final String destination) throws IllegalArgumentExcep

List<InetSocketAddress> parsedDestinations = DestinationParser.parse(destination, DEFAULT_PORT);

addDestinations(parsedDestinations.toArray(new InetSocketAddress[parsedDestinations.size()]));
addDestinations(parsedDestinations.toArray(new InetSocketAddress[0]));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ protected void prepareForDeferredProcessing(Event event) {

protected String calculateThreadName() {
List<Object> threadNameFormatParams = getThreadNameFormatParams();
return String.format(threadNameFormat, threadNameFormatParams.toArray(new Object[threadNameFormatParams.size()]));
return String.format(threadNameFormat, threadNameFormatParams.toArray());
}

protected List<Object> getThreadNameFormatParams() {
Expand Down