Bump to Logback 1.3.0-beta0 #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brenuart
commented
Aug 14, 2022
brenuart
commented
- Build against Logback 1.3.0
- Execute backward compatibility tests against latest Logback 1.2.x
- Comment links to Logback javadoc (generation fails under Java8 because logback docs have replace "package-list" by "element-list")
Build against Logback 1.3.0 Execute backward compatibility tests against latest Logback 1.2.x
Javadoc generation fails under Java8 because the Logback javadoc does not contain a "package-list" index file anymore since version 1.3.0. It seems to work however with Java 9 and 11. Note: "package-list" has been replaced by "element-list" in Java 9... Newer jdk versions seem to look for "element-list" first and fallback to "package-list". A possible workaround is to build the project (and generate javadoc) using Java 9 instead of 8. In the meantime links to Logback apidoc are commented.
Codecov Report
@@ Coverage Diff @@
## main #832 +/- ##
=========================================
Coverage 70.97% 70.97%
Complexity 1255 1255
=========================================
Files 167 167
Lines 4807 4807
Branches 498 498
=========================================
Hits 3412 3412
Misses 1150 1150
Partials 245 245 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.