-
Notifications
You must be signed in to change notification settings - Fork 65
Deps: allow any scheduler version with plugin #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
145980b
sum
kares 5cc8bff
Test: make spec pass easy on CI
kares 4f9e022
unpin rufus-scheduler ~> 3.0.9
kares a043181
bump + changelog
kares b6505a0
Temp: let's see if failure is due new rufus
kares bbfe024
Revert "Temp: let's see if failure is due new rufus"
kares b3d862e
Refactor: no @interval_thread or stud usage around
kares 3efb809
Test: apply a lag due CI :red: against 8.1-SNAPSHOT
kares 6c104fb
Test: move Timecop setup/return to before/after hooks
kares 0607035
proper scope for allowed_lag override
kares b3ae84c
more lag
kares f88e40c
Refactor: to use graceful scheduler shutdown
kares dda1a80
10
kares 7cfc654
Refactor: join on thread instead of queue (in 3.8)
kares 6b70eb6
Temp: long lag
kares 6c6cd17
try a few times
kares cc08287
Revert testing timeout increase (due newer base img)
kares 9287c55
Merge branch 'main' into rufus
kares 53388ac
Test: make sure test does not leak scheduler
kares e52b01c
Test: dry-out + do not leak scheduler
kares ae0d99c
allow more lag on scheduler to shut-down
kares d6074f7
set -Xms128m -Xmx1g -XX:MaxMetaspaceSize=256m
kares 2dd8a3f
account for CI lag within sleep
kares 901044e
let's bound test to ~1G heap+meta space
kares 10ef111
Temp: lag up to 20
kares 1ac1f5e
CI: test against 3.0.9 scheduler version, for now
kares 8ba255e
LOG_LEVEL=info
kares 4ded64e
-Djava.security.egd=/dev/./urandon
kares 0141c35
Test: re-invent the plugin interrupt spec
kares 9ed546d
dump ruby threads
kares f397826
puts plugin_thread.alive?
kares 793801a
DRAFT: close http client completely!
kares f48bc6e
print threads in either case
kares 4eebf47
Test: release every plugin we start!
kares a8dafb4
TEST: back to @scheduler.join for now
kares 85d258b
Test: use less (pool thread) resources in tests
kares 8ae1419
more tries
kares 3c79dcc
sleep for a bit
kares 58d6198
adjust scheduler specs for predictability
kares 8b494fc
puts raw thread dump
kares d6f0e72
dangling around trying to JIT a block turn it OFF
kares ceae70b
print more thread dump details
kares 8726a33
LOG_LEVEL=debug
kares d370769
back to join-ing on thread - makes sense!
kares f86e45c
avoid shutdown(:wait) as it's over engineered
kares 1f1b77e
Revert "LOG_LEVEL=debug"
kares 5f13700
Revert "print more thread dump details"
kares 438d017
Revert "puts raw thread dump"
kares f630b2b
Revert "sleep for a bit"
kares 18f09c9
Revert "print threads in either case"
kares e1af18b
Revert "puts plugin_thread.alive?"
kares 9b1af8b
Revert "dump ruby threads"
kares d108f71
Revert "Test: re-invent the plugin interrupt spec"
kares d1e9320
undo docker.env overrides
kares 6450158
Revert "DRAFT: close http client completely!"
kares e51ec6c
Test: spec close-ing as well
kares 6d9df13
restore previous close/stop impl
kares 6cc115f
do not override close - stop is called before
kares 4252bcb
Update CHANGELOG.md
kares a38b589
Refactor: restore @scheduler.stop if @scheduler
kares File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
back to join-ing on thread - makes sense!
- Loading branch information
commit d370769c7413829deaabbe675b709acbc6b1b508
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in rufus 3.0.9
@scheduler.joinis ~@scheduler.thread.join.however in latest rufus 3.8 the
@scheduler.joindoes a blocking Queue#pop so this makes it behave the same across versions ...