Use newer Unprocessable Content naming for 422 #1638
Merged
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMacTia
requested changes
Sep 20, 2025
Member
There was a problem hiding this comment.
Thank you @tylerhunt and apologies for taking so long to get back to you 🙇
I appreciate the change, but I'd suggest using a straight constant assignment to provide backwards compatibility as opposed to turning UnprocessableEntity into a module and including it in the new class.
Appreciate this PR has been open for a while, so I'll proceed with this change myself.
lib/faraday/error.rb
Outdated
| end | ||
|
|
||
| # Used to provide compatibility with legacy error name. | ||
| module UnprocessableEntityError |
Member
There was a problem hiding this comment.
I'd rather use a constant assignment to keep this as a class
iMacTia
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename
Faraday::UnprocessableEntityErrortoFaraday::UnprocessableContentErrorbut provide compatibility with the older error constant through the use of an included module.This is based on the status code name specified by IETF RFC 9110. Rack 3.1 was updated to account for this change (rack/rack#2137), and Rails has added support for it (rails/rails#53383), as well.