Add rpath for sharp-libvips in binding.gyp #4452
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpath setting lists the path in which the linker should try to load the required dylibs. Paths are relative to the library, so with the current setting of:
A library located in
node_modules/pkg/lib/sharp/lib.nodewill try to find the libvips binary in the hoistednode_modules/@img/sharp-libvips-*/libpath, but not in the non-hoisted pathnode_modules/pkg/node_modules/@img/sharp-libvips-*/lib.This PR adds the non-hoisted path to the rpath list so it properly locates the file when it's found as a direct dependency.
We stumbled upon this issue while attempting to solve in Yarn the root cause why you rely on Yarn-specific code.