merge from master #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always use hideNavBar in example instead showNavigationBar to avoid confusion
Fix pop handling for multi-pop situations
use hideNavBar in example. close #262
Pass updated props to an existing route
follow up #270 always use hideNavBar in example instead showNavigationBar to avoid confusion
use hideNavBar in README example
The NoTransition scene config produces an interpolator function with a divide by zero, which can cause scenes to have opacity=NaN when directionAdjustedProgress is set to 1. This bad value is interpreted on Simulator as opacity=1 (bug does not appear) but on my device it shows up as opacity=0 (scene shows briefly and then disappears). The 'constant' type seems more appropriate here.
typo in README
NoTransition scene config causes blank scenes
Fixes crash when currentRouter is already null.
ExRouter add onTransitionToTop , like ExNavigator transitionToTop , …
Added missing defaultRoute action to tabbar
Check if current router exists
When invoking Actions.refresh({title: 'Changed'}), the call to
super.render() in ExNavigationBar calls back into getTitle() on
ExRouteAdapter to determine the title to display in the navigation bar
This patch first checks the provided props before falling back to the
previous behavior.
Use route props first when determining route title
upgrade examples to React Native 0.20.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.