#1052 fix lsd pipe output#1059
Conversation
|
closes #1072 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GottZ, WangMengabc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
sorry for the delay, some personal issues have trapped me recently. I will look into PRs in following days |
welcome back! |
|
the change lgtm, but we may have some issues on tests, I am working on it, and will merge after I fix the tests |
Signed-off-by: Wei Zhang <kweizh@gmail.com>
Signed-off-by: Wei Zhang <kweizh@gmail.com>
Signed-off-by: Wei Zhang <kweizh@gmail.com>
|
I'm at FrOSCon right now, lsd just got presented at a talk where I just had to mention this bug. |
|
Hi @GottZ, thanks so much for provide the info about the talk, it was excited to know about people using lsd. as for the bug, I beleive this PR has fix it and it should be good to go now, can you hekp checking the lsd from https://github.com/WangMengabc/lsd/tree/master, or I can build a binary for you if needed. |
it's flawless. thanks! |
|
thanks for the help, let's create a new release for this |

TODO
cargo fmt