Skip to content

Add icon for .cmd#1117

Merged
zwpaper merged 1 commit intolsd-rs:masterfrom
spenserblack:master
Feb 23, 2025
Merged

Add icon for .cmd#1117
zwpaper merged 1 commit intolsd-rs:masterfrom
spenserblack:master

Conversation

@spenserblack
Copy link
Contributor

@spenserblack spenserblack commented Jan 15, 2025

.cmd files are almost identical to .bat, with slightly different syntax and error handling.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@spenserblack
Copy link
Contributor Author

spenserblack commented Jan 15, 2025

Regarding the "TODO", I naively grepped for .bat and didn't find any tests or docs (just the one line in src/theme/icon.rs), so I'm assuming the other steps aren't necessary for this change.

@spenserblack spenserblack marked this pull request as ready for review January 15, 2025 17:33
@spenserblack spenserblack requested a review from zwpaper as a code owner January 15, 2025 17:33
@zwpaper zwpaper merged commit db5d5b5 into lsd-rs:master Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants