update various dependencies#984
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: decathorpe The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #984 +/- ##
==========================================
+ Coverage 84.44% 85.08% +0.63%
==========================================
Files 51 51
Lines 5067 5035 -32
==========================================
+ Hits 4279 4284 +5
+ Misses 788 751 -37 ☔ View full report in Codecov by Sentry. |
|
Hi @decathorpe, thanks for the update, as you can see CI, once we upgrade the can you help to fix it? |
|
I briefly looked at the failure, and it seems to be a toolchain issue? I have no idea why updating Rust code should cause linker failures. If it's dirs v5 that causes the issue, I can drop that one from the batch and we can look into the failure separately. |
|
that would also be okay to leave dirs in a separate PR |
|
I've dropped the dirs v4 → v5 update for now. One thing that looks suspicious is that with v5, it now uses |
|
Strange. I dropped the dirs update, and the windows-gnu builds still failed in the same way. |
- update dirs from v4 to v5 (no code changes) - update term_grid from v0.1 to v0.2 (small code changes) - update terminal_size from v0.1 to v0.3 (no code changes) - update lscolors from v0.15 to v0.16 (no code changes) - update serde_yaml from v0.8 to v0.9 (no code changes) The term_grid update required small changes to the use of `term_grid::Cell` because with v0.2, it is possible to specify the alignment within the cell. Adding `Alignment::Left` should preserve the current behaviour. This commit also includes the changes generated by "cargo update", which seems not to have been run in a long time, causing very old versions to be pulled in.
|
I tried something else, maybe it changes things, maybe not. 🤞🏼 |
|
Looks like good ol' (After |
|
thanks so much for the update! |
|
Great, thanks! |
This is a followup for #938.
The term_grid update required small changes to the use of
term_grid::Cellbecause with v0.2, it is possible to specify the alignment within the cell. AddingAlignment::Leftshould preserve the current behaviour.