Merge pull request segment-integrations#5 from segment-integrations/revenue-fallback

update properties on trackEvent and revenue fallback

Author: sperand-io

lib/index.js

@@ -53,18 +53,22 @@ Optimizely.prototype.initialize = function() {
 };
 
 /**
- * Track.
+ * Track. trackEvent can only send one property, revenue
+ * We fall back to total if it's on the call and revenue is not
  *
  * https://www.optimizely.com/docs/api#track-event
+ * http://developers.optimizely.com/javascript/reference/#api-function-calls
  *
  * @api public
  * @param {Track} track
  */
 
 Optimizely.prototype.track = function(track) {
   var props = track.properties();
-  if (props.revenue) props.revenue *= 100;
-  push('trackEvent', track.event(), props);
+  var payload = {};
+  var revenue = props.revenue || props.total || props.value;
+  if (revenue) payload.revenue = revenue *= 100;
+  push('trackEvent', track.event(), payload);
 };
 
 /**

test/index.test.js

@@ -161,11 +161,9 @@ describe('Optimizely', function() {
         analytics.called(window.optimizely.push, ['trackEvent', 'event', {}]);
       });
 
-      it('should send an event and properties', function() {
+      it('shouldn\'t send properties it can\'t process', function() {
         analytics.track('event', { property: true });
-        analytics.called(window.optimizely.push, ['trackEvent', 'event', {
-          property: true
-        }]);
+        analytics.called(window.optimizely.push, ['trackEvent', 'event', {}]);
       });
 
       it('should change revenue to cents', function() {
@@ -174,6 +172,20 @@ describe('Optimizely', function() {
           revenue: 999
         }]);
       });
+
+      it('should fallback to total if revenue isn\'t on the call', function() {
+        analytics.track('event', { total: 9.99 });
+        analytics.called(window.optimizely.push, ['trackEvent', 'event', {
+          revenue: 999
+        }]);
+      });
+
+      it('should fallback to value if revenue and total aren\'t on the call', function() {
+        analytics.track('event', { value: 9.99 });
+        analytics.called(window.optimizely.push, ['trackEvent', 'event', {
+          revenue: 999
+        }]);
+      });
     });
 
     describe('#page', function() {
@@ -183,27 +195,12 @@ describe('Optimizely', function() {
 
       it('should send an event for a named page', function() {
         analytics.page('Home');
-        analytics.called(window.optimizely.push, ['trackEvent', 'Viewed Home Page', {
-          name: 'Home',
-          path: window.location.pathname,
-          referrer: document.referrer,
-          title: document.title,
-          search: window.location.search,
-          url: window.location.protocol + '//' + window.location.hostname + (window.location.port ? ':' + window.location.port : '') + window.location.pathname + window.location.search
-        }]);
+        analytics.called(window.optimizely.push, ['trackEvent', 'Viewed Home Page', {}]);
       });
 
       it('should send an event for a named and categorized page', function() {
         analytics.page('Blog', 'New Integration');
-        analytics.called(window.optimizely.push, ['trackEvent', 'Viewed Blog New Integration Page', {
-          category: 'Blog',
-          name: 'New Integration',
-          path: window.location.pathname,
-          referrer: document.referrer,
-          title: document.title,
-          search: window.location.search,
-          url: window.location.protocol + '//' + window.location.hostname + (window.location.port ? ':' + window.location.port : '') + window.location.pathname + window.location.search
-        }]);
+        analytics.called(window.optimizely.push, ['trackEvent', 'Viewed Blog New Integration Page', {}]);
       });
     });
   });