This repository was archived by the owner on Jun 27, 2019. It is now read-only.
update properties on trackEvent and revenue fallback #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
look_ing_ gtm — ping me once you add |
wcjohnson11
force-pushed
the
revenue-fallback
branch
from
25e7b10 to
50c4254
Compare
|
@sperand-io updated the fallback, lmk 🐩 |
|
@wcjohnson11 nice, lgtm! |
sperand-io
added a commit
that referenced
this pull request
Sep 8, 2015
update properties on trackEvent and revenue fallback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to send all properties to Optimizely but they can only accept one property,
revenue. I've updated our integration and the tests to reflect this and I've also added a fallback to passtotalasrevenueif the latter isn't included in the call's properties.Some customers want to be able to track the variable monetary values they get with Optimizely test variations but they don't want to use the word revenue since the value they want to pass through isn't equivalent to revenue and they don't want to conflate the two in their raw data to see that in Optimizely.