-
-
Notifications
You must be signed in to change notification settings - Fork 0
ci(deps): Update dependency socket.io to v2 [SECURITY] #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
develop
Choose a base branch
from
renovate/npm-socket.io-vulnerability
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b5e89e to
5d3c8d1
Compare
d509309 to
8eab458
Compare
8eab458 to
c4e7097
Compare
c4e7097 to
d5f5194
Compare
d5f5194 to
5a77e8f
Compare
5a77e8f to
2d5f707
Compare
2d5f707 to
74be335
Compare
74be335 to
9b22c06
Compare
9b22c06 to
3cf46aa
Compare
3cf46aa to
a3feb0e
Compare
a3feb0e to
4135796
Compare
4135796 to
82084fb
Compare
82084fb to
d901df4
Compare
d901df4 to
2746291
Compare
60b0f4a to
04212ff
Compare
04212ff to
aaa4b6a
Compare
ecf8396 to
3928f4d
Compare
3928f4d to
3193ab3
Compare
3193ab3 to
21ce0b3
Compare
21ce0b3 to
1cda985
Compare
1cda985 to
af518bf
Compare
af518bf to
2a7fd8d
Compare
2a7fd8d to
3a37085
Compare
3a37085 to
f75e7b4
Compare
f75e7b4 to
368e763
Compare
368e763 to
1ca3cb6
Compare
1ca3cb6 to
f1fc580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
~1.3.7→~2.5.1~1.7.4→~2.5.1GitHub Vulnerability Alerts
CVE-2020-28481
The package socket.io before 2.4.0 are vulnerable to Insecure Defaults due to CORS Misconfiguration. All domains are whitelisted by default.
CVE-2024-38355
Impact
A specially crafted Socket.IO packet can trigger an uncaught exception on the Socket.IO server, thus killing the Node.js process.
Affected versions
4.6.2...latest3.0.0...4.6.1[email protected](at least)2.3.0...2.5.0[email protected]Patches
This issue is fixed by socketio/socket.io@15af22f, included in
[email protected](released in May 2023).The fix was backported in the 2.x branch today: socketio/socket.io@d30630b
Workarounds
As a workaround for the affected versions of the
socket.iopackage, you can attach a listener for the "error" event:For more information
If you have any questions or comments about this advisory:
Thanks a lot to Paul Taylor for the responsible disclosure.
References
Release Notes
socketio/socket.io (socket.io)
v2.5.1Compare Source
Bug Fixes
Links:
-~3.6.0(no change)~7.5.10v2.5.0Compare Source
The default value of the
maxHttpBufferSizeoption has been decreased from 100 MB to 1 MB, in order to prevent attacks by denial of service.Security advisory: GHSA-j4f2-536g-r55m
Bug Fixes
Links:
~3.6.0(diff)~7.4.2v2.4.1Compare Source
This release reverts the breaking change introduced in
2.4.0(f78a575).If you are using Socket.IO v2, you should explicitly allow/disallow cross-origin requests:
In any case, please consider upgrading to Socket.IO v3, where this security issue is now fixed (CORS is disabled by default).
Reverts
Links:
~3.5.0~7.4.2v2.4.0Compare Source
Related blog post: https://socket.io/blog/socket-io-2-4-0/
Features (from Engine.IO)
Bug Fixes
Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (
Access-Control-Allow-xxx) to any domain. This will not be the case anymore, and you now have to explicitly enable it.Please note that you are not impacted if:
originsoption to restrict the list of allowed domainsThis commit also removes the support for '*' matchers and protocol-less URL:
To restore the previous behavior (please use with caution):
See also:
Thanks a lot to @ni8walk3r for the security report.
Links:
~3.5.0~7.4.2v2.3.0Compare Source
This release mainly contains a bump of the
engine.ioandwspackages, but no additional features.Links:
~3.4.0(diff: socketio/engine.io@3.3.1...3.4.2)^7.1.2(diff: websockets/ws@6.1.2...7.3.1)v2.2.0Compare Source
Features
Bug fixes
Links
~3.3.1(diff: socketio/engine.io@3.2.0...3.3.1)~6.1.0(diff: websockets/ws@3.3.1...6.1.2)v2.1.1Compare Source
Features
Bug fixes
(client) fire an error event on middleware failure for non-root namespace (socketio/socket.io-client#1202)
Links:
~3.2.0~3.3.1v2.1.0Compare Source
Features
Bug fixes
Important note⚠️ from Engine.IO 3.2.0 release
There are two non-breaking changes that are somehow quite important:
wswas reverted as the default wsEngine (socketio/engine.io#550), as there was several blocking issues withuws. You can still useuwsby runningnpm install uws --savein your project and using thewsEngineoption:pingTimeoutnow defaults to 5 seconds (instead of 60 seconds): socketio/engine.io#551Links:
~3.2.0(diff: socketio/engine.io@3.1.0...3.2.0)~3.3.1(diff: websockets/ws@2.3.1...3.3.1)v2.0.4Compare Source
Bug fixes
Links:
engine.io: -ws: -v2.0.3Compare Source
Bug fixes
Links:
engine.io: -ws: -v2.0.2Compare Source
Bug fixes
Links:
engine.io: -ws: -v2.0.1Compare Source
Bug fixes
- update path of client file (#2934)
Links:
engine.io: -ws: -v2.0.0Compare Source
This major release brings several performance improvements:
uws is now the default Websocket engine. It should bring significant improvement in performance (particularly in terms of memory consumption) (https://github.com/socketio/engine.io/releases/tag/2.0.0)
the Engine.IO and Socket.IO handshake packets were merged, reducing the number of roundtrips necessary to establish a connection. (#2833)
it is now possible to provide a custom parser according to the needs of your application (#2829). Please take a look at the example for more information.
Please note that this release is not backward-compatible, due to:
Please also note that if you are using a self-signed certificate,
rejectUnauthorizednow defaults totrue(socketio/engine.io-client#558).Finally, the API documentation is now in the repository (here), and the content of the website here. Do not hesitate if you see something wrong or missing!
The full list of changes:
localflag (#2816)clientsmethod in the API documentation (#2812)Besides, we are proud to announce that Socket.IO is now a part of open collective: https://opencollective.com/socketio. More on that later.
v1.7.4Compare Source
v1.7.3Compare Source
v1.7.2Compare Source
v1.7.1Compare Source
(following
socket.io-clientupdate)v1.7.0Compare Source
localflag (#2628)v1.6.0Compare Source
v1.5.1Compare Source
clientin test script (#2731)v1.5.0Compare Source
v1.4.8Compare Source
v1.4.7Compare Source
v1.4.6Compare Source
v1.4.5Compare Source
v1.4.4Compare Source
v1.4.3Compare Source
v1.4.2Compare Source
v1.4.1Compare Source
v1.4.0Compare Source
Configuration
📅 Schedule: Branch creation - "" in timezone America/Lima, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.