Conversation
|
Hi @wjhrdy, Thank you very much for taking your time to add a script to generate an .epub version of this resources. I really appreciate that. There is one issue (not very critical), so if you can address it, that would be great, otherwise just lets me know, I can accept this even without the fix. Although there are few things not totally relate to the code itself:
Thank you again Found 1 issue:
The counter should only be incremented when a new image is actually rendered, not on cache hits. Consider storing the filename along with the image bytes in the cache, or generating filenames deterministically based on a hash of the mermaid code. |
- Introduced a new script to build an EPUB from markdown files, enhancing documentation accessibility. - Added a GitHub Actions workflow for automated EPUB builds on version tag pushes. - Created the initial EPUB file 'claude-howto-guide.epub' for distribution. This update streamlines the process of creating and releasing the Claude How-To guide in EPUB format.
|
Hi @wjhrdy , Binary file committed claude-howto-guide.epub Issue: The generated .epub file is committed to the repository. This is typically not recommended
Please: Add *.epub to .gitignore and remove the binary from the PR. The GitHub Actions workflow will create releases with the artifact. Script path issue if __name__ == '__main__':
root = Path(__file__).parent
output = root / "claude-howto-guide.epub"
create_epub(root, output)Issue: The script sets root to scripts/ directory (where the script lives), not the repository Suggested fix: if __name__ == '__main__':
root = Path(__file__).parent.parent # Go up one level to repo root
output = root / "claude-howto-guide.epub"
create_epub(root, output)Thank you again, I will merge as soon as these issues are addressed. I am really looking forward to make the first PR merge with you! |
|
Its all good, this is the process. Happy to contribute. |
|
How do you feel about just gitignoring the epub? |
that works for me |
…EPUB files - Added blog-posts/ to .gitignore to prevent tracking of blog-related files. - Included rule to ignore all EPUB files in the root directory for cleaner repository management.
Renamed "Use Plan Mode for safety" to "Start with a plan" and repositioned it as the recommended way to begin any task. Added a hands-on exercise where users plan a Nike market report in Plan Mode, review the plan, then switch to normal mode to execute. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
You can run this with ./build_epub.py
assuming you have
uvinstalled